Skip to content

Add a testcase for #926 - #940

Merged
NWilson merged 3 commits into
mainfrom
user/niwilson/jit-fallthrough-test
Aug 12, 2026
Merged

Add a testcase for #926#940
NWilson merged 3 commits into
mainfrom
user/niwilson/jit-fallthrough-test

Conversation

@NWilson

@NWilson NWilson commented Aug 9, 2026

Copy link
Copy Markdown
Member

No description provided.

@NWilson NWilson added this to the 10.48 milestone Aug 11, 2026

@zherczeg zherczeg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/pcre2test_inc.h
Comment thread testdata/testinput17
# Check UTF validation when falling back from a partially-compiled JIT pattern
# to the interpreter

#if unicode

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a cunning (?) thing I added. We have many test files... but not for the case must-support-JTI AND must-support-Unicode.

Instead of making a new file for every combination of conditions, I'm starting to make the tests use conditional constructs.

@NWilson
NWilson merged commit e2f1001 into main Aug 12, 2026
39 checks passed
@NWilson
NWilson deleted the user/niwilson/jit-fallthrough-test branch August 12, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants